Commit graph

21962 commits

Author SHA1 Message Date
Dorra Jaouad
d19a764143 fix: RTL support in call view
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2025-01-30 16:42:06 +01:00
Maksim Sukharev
9815309a80
Merge pull request #13876 from nextcloud/fix/noid/certificate-service-ts 2025-01-30 14:31:57 +01:00
Maksim Sukharev
d1c7079bd7
Merge pull request #14236 from nextcloud/feat/noid/edit-drafts-frontend 2025-01-30 14:23:19 +01:00
Maksim Sukharev
774682de64 feat(polls): allow to update drafts
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2025-01-30 14:13:35 +01:00
Maksim Sukharev
af7f428b8c fix: migrate certificateService to .ts
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2025-01-30 13:53:00 +01:00
Maksim Sukharev
fdf3aa3c88 fix: rename certificateService to .ts
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2025-01-30 13:48:29 +01:00
Dorra
e3b852b577
Merge pull request #14143 from nextcloud/fix/search-messages-follow-up
fix: user contacts menu instead of conversation participants (there c…
2025-01-30 10:31:37 +01:00
Dorra Jaouad
c24033f923 fix(SearchMessagesTab): reset search after removing filters
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
2025-01-30 10:28:38 +01:00
Dorra Jaouad
55546c7dda fix(SearchMessagesTab): add items navigation
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
2025-01-30 09:16:38 +01:00
Maksim Sukharev
508bbdb502 fix(Poll): refactor styles
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2025-01-30 09:12:01 +01:00
Maksim Sukharev
5542a624f1 feat(polls): handle update-drafts API endpoint
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2025-01-30 09:12:01 +01:00
Daniel Calviño Sánchez
0171ecdc5b
Merge pull request #14095 from nextcloud/fix-known-false-positives-in-connection-warning
Fix (known) false positives in connection warning
2025-01-30 02:49:17 +01:00
Nextcloud bot
13fd4ec42a
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-01-30 00:35:15 +00:00
Maksim Sukharev
93b87b4a7d
Merge pull request #14248 from nextcloud/fix/noid/jest-date-now 2025-01-29 19:31:48 +01:00
Maksim Sukharev
cd15420cbf fix(test): replace jest.spyOn with jest.useFakeTimers
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2025-01-29 18:23:42 +01:00
Daniel Calviño Sánchez
048c50585b fix: Fix quality report when packet count regresses
Due to a bug in Firefox and/or Janus, when using simulcast video the
remote report for one of the streams (typically the lowest quality one)
may start with garbage values. This causes the received packet count to
be reported the maximum integer value minus the packet lost count (which
is usually around a few thousands). When newer stats arrive the received
packets start to increase from that extremely high value, and eventually
it overflows, causing the received packet count to go back from
~4294967295 to ~0.

In other cases it was seen that the received packet count can regress a
few values, although it is not clear when or why (this was much rarer
and not reproducible, unlike the scenario described above).

To prevent the regressed value from distorting the analysis due to the
packet count being < 0, and as in both cases once the packet count
regressed the received packet count in all following stat reports
increase from the regressed value, now the stats are reset when a lower
packet count is found.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2025-01-29 15:46:48 +01:00
Daniel Calviño Sánchez
70530ac6df fix: Do not report very bad quality with a low packets count
In the past it was observed that, even for small videos, 10 packets per
second was a reasonable threshold to detect connection issues even if
there were no lost packets. However, nowadays it seems that it can
sometimes trigger a false positive (typically when the background blur
is enabled and the video quality is reduced due to being in a call with
several participants), so for now the connection problem is no longer
reported to the user but just logged.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2025-01-29 15:46:48 +01:00
Daniel Calviño Sánchez
a5707cda35 fix: Handle timestamps not updated when stats are stalled
In the past it was observed that the timestamp and round trip time were
updated when the stats stalled (so only the received packets actually
stalled). However, nowadays it seems that the timestamp and round trip
time can also stall. This caused the stalled timestamp to be computed as
0, and that in turn messed with the rest of calculations (for example,
generating a NaN for the number of packets per second) and causing a
"very bad quality" to be wrongly reported. To solve that now the
timestamps are evenly distributed when they unstall.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2025-01-29 15:46:48 +01:00
Daniel Calviño Sánchez
a6e5fdad6b fix: Fix calculating stats without enough meaningful values
When the initial stats reports are added the first value of cumulative
stats is used as a base when converting the rest of values to relative.
Therefore, that initial value is not meaningful and should not be used
in calculations, as otherwise the reported quality would be off. Due to
that now no quality is reported until the values of the first report
added were shifted.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2025-01-29 15:46:47 +01:00
Daniel Calviño Sánchez
e24512826a test: Add unit tests for missing remote packet count
Chromium does not provide "packetsReceived" in "remote-inbound-rtp"

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2025-01-29 15:46:47 +01:00
Daniel Calviño Sánchez
1ef6f3b07c test: Add unit tests for analyzing the sender connection
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2025-01-29 15:46:47 +01:00
Maksim Sukharev
00e504a2c1
Merge pull request #14152 from nextcloud/fix/14029/muted-speaker 2025-01-29 12:02:46 +01:00
Maksim Sukharev
aadd013028 fix(LocalAudioControlButton): show popup when microphone is muted
- detach logic from TopBar

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2025-01-29 10:46:47 +01:00
Maksim Sukharev
66491fd81d
Merge pull request #14208 from nextcloud/fix/14207/i18n 2025-01-29 10:32:40 +01:00
Nextcloud bot
01b31a5796
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-01-29 00:25:42 +00:00
Maksim Sukharev
db91e82b7d
Merge pull request #14237 from nextcloud/fix/noid/dragover 2025-01-28 17:12:09 +01:00
Maksim Sukharev
456277e4fa
Merge pull request #14212 from nextcloud/fix/noid/typescript-support 2025-01-28 16:24:48 +01:00
Maksim Sukharev
8ff367340d chore(CI): add typecheck workflow
- sourced from Talk Desktop

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2025-01-28 16:04:24 +01:00
Maksim Sukharev
f01a07c795 fix(ts): rename constants.js to constants.ts
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2025-01-28 16:04:24 +01:00
Maksim Sukharev
b31195db61 fix(sidebarStore): migrate to TS
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2025-01-28 16:04:24 +01:00
Maksim Sukharev
9296aafc86 fix(PollEditor): rework form validation
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2025-01-28 16:00:47 +01:00
Maksim Sukharev
c125c742c3 fix(MediaSettingsTabs): type inline styles
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2025-01-28 16:00:47 +01:00
Maksim Sukharev
02b4b2aac1 fix(ts): fix non-captured type errors
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2025-01-28 16:00:47 +01:00
Maksim Sukharev
99fe9805b7 chore(ts): enable check in Vue files
- sourced from Talk Desktop

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2025-01-28 16:00:47 +01:00
Maksim Sukharev
02f9ff1bdc chore(deps): install @total-typescript/ts-reset library v0.6.1
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2025-01-28 16:00:47 +01:00
Maksim Sukharev
f0adbc1a62 chore(deps): install vue-tsc library v2.2.0
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2025-01-28 16:00:47 +01:00
Maksim Sukharev
c2a3ad0e00
Merge pull request #14232 from nextcloud/fix/noid/calendar-insertnodebefore 2025-01-28 15:24:28 +01:00
Dorra Jaouad
35c0da1d33 fix(ChatView): center dragover on MessagesList only and migrate to NcEmptyContent
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
2025-01-28 13:02:24 +01:00
Nextcloud bot
36bc222fb8
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-01-28 00:25:42 +00:00
Maksim Sukharev
b8d92a7fb6
Merge pull request #14169 from nextcloud/chore/stylelint-use-logical 2025-01-27 18:31:44 +01:00
Maksim Sukharev
bd8e6914ed fix(CalendarEventsDialog): fix focus-trap issues
- add padding to empty content

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2025-01-27 18:04:58 +01:00
Maksim Sukharev
d7fe6413ab fix(SpeakingWhileMutedWarner): replace toast message with popup
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2025-01-27 17:36:57 +01:00
Maksim Sukharev
879ace49c7 fix(SpeakingWhileMutedWarner): add timeout to hide message in case of constant noise (7 seconds)
- also hide message on destroy

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2025-01-27 17:35:39 +01:00
Dorra
7124e612cf
Merge pull request #14163 from nextcloud/fix/noid/rtl-support-talk
fix(bidi): adjust UI to RTL support
2025-01-27 16:14:56 +01:00
Dorra Jaouad
4a1c64f3e4 Fix(NewMessage): adjust items dir based on the selected language. It's temporary until we find a way to fix the emoji picker on selected language and not on user's language (new text message)
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
2025-01-27 15:29:44 +01:00
Maksim Sukharev
6b93ad4dfa
Merge pull request #14205 from nextcloud/fix/noid/ease-message-list 2025-01-27 13:21:50 +01:00
Maksim Sukharev
32cee2f906 fix(CalendarEventsDialog): keep components in one node
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2025-01-27 12:58:46 +01:00
Anna
932ac148a0
Merge pull request #14206 from nextcloud/bugfix/noid/better-bot-install
fix(bots): Fix default and restrict features of app bots when install with event
2025-01-27 12:55:46 +01:00
Dorra
22f0dbb54b
Merge pull request #14228 from nextcloud/fix/noid/leftsidebar-border
fix(LeftSidebar): remove outdated style
2025-01-27 11:20:41 +01:00
Maksim Sukharev
2ed400955d
Merge pull request #14209 from nextcloud/fix/13944/empty-pasword-allow 2025-01-27 10:59:37 +01:00