From 92024f8de392777f3719b0a2f10075efa36860c3 Mon Sep 17 00:00:00 2001
From: Maksim Sukharev <antreesy.web@gmail.com>
Date: Sat, 29 Nov 2025 15:45:17 +0100
Subject: [PATCH] fix: lint code

- disable new jsdoc rules
- wrap some jsdoc inline tags
- cleanup redundant close-on-click-outside

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
---
 eslint.config.mjs                                    | 5 +++++
 src/components/ExtendOneToOneDialog.vue              | 3 +--
 src/components/GuestWelcomeWindow.vue                | 1 -
 src/components/NewMessage/NewMessageUploadEditor.vue | 1 -
 src/components/SetGuestUsername.vue                  | 2 +-
 src/services/conversationsService.ts                 | 2 +-
 src/stores/actor.ts                                  | 2 +-
 src/utils/e2ee/JitsiEncryptionWorkerContext.js       | 4 ++--
 src/utils/handleUrl.ts                               | 2 +-
 src/utils/webrtc/simplewebrtc/simplewebrtc.js        | 6 +++---
 10 files changed, 15 insertions(+), 13 deletions(-)

diff --git a/eslint.config.mjs b/eslint.config.mjs
index b2ffc5807f..8b6b0a7ea4 100644
--- a/eslint.config.mjs
+++ b/eslint.config.mjs
@@ -44,8 +44,13 @@ export default [
 			'@typescript-eslint/no-unused-expressions': 'off', // non-fixable
 			'@typescript-eslint/no-unused-vars': 'off', // non-fixable
 			'@typescript-eslint/no-use-before-define': 'off', // non-fixable
+			'jsdoc/check-tag-names': 'off', // need to respect JS
+			'jsdoc/reject-function-type': 'off', // need to respect JS
+			'jsdoc/reject-any-type': 'off', // need to respect JS
+			'jsdoc/require-function-type': 'off', // need to respect JS
 			'jsdoc/require-param-type': 'off', // need to respect JS
 			'jsdoc/require-param-description': 'off', // need to respect JS
+			'jsdoc/require-throws-type': 'off', // need to respect JS
 			'no-console': 'off', // non-fixable
 			'no-unused-vars': 'off', // non-fixable
 			'no-use-before-define': 'off', // non-fixable
diff --git a/src/components/ExtendOneToOneDialog.vue b/src/components/ExtendOneToOneDialog.vue
index 320a901efb..a81b419d5b 100644
--- a/src/components/ExtendOneToOneDialog.vue
+++ b/src/components/ExtendOneToOneDialog.vue
@@ -74,8 +74,7 @@ async function extendOneToOneConversation() {
 <template>
 	<NcPopover
 		:container="container"
-		popup-role="dialog"
-		close-on-click-outside>
+		popup-role="dialog">
 		<template #trigger>
 			<NcButton
 				variant="tertiary"
diff --git a/src/components/GuestWelcomeWindow.vue b/src/components/GuestWelcomeWindow.vue
index 2bc5ff4557..7daaf4e72f 100644
--- a/src/components/GuestWelcomeWindow.vue
+++ b/src/components/GuestWelcomeWindow.vue
@@ -6,7 +6,6 @@
 <template>
 	<NcModal
 		no-close
-		:close-on-click-outside="false"
 		:label-id="dialogHeaderId"
 		size="small">
 		<div class="modal__content">
diff --git a/src/components/NewMessage/NewMessageUploadEditor.vue b/src/components/NewMessage/NewMessageUploadEditor.vue
index f5e93357ce..93860f2ca8 100644
--- a/src/components/NewMessage/NewMessageUploadEditor.vue
+++ b/src/components/NewMessage/NewMessageUploadEditor.vue
@@ -8,7 +8,6 @@
 		v-if="showModal"
 		ref="modal"
 		:size="isVoiceMessage ? 'small' : 'normal'"
-		:close-on-click-outside="false"
 		:label-id="dialogHeaderId"
 		@close="handleDismiss">
 		<div
diff --git a/src/components/SetGuestUsername.vue b/src/components/SetGuestUsername.vue
index f3013843e6..e4d846d942 100644
--- a/src/components/SetGuestUsername.vue
+++ b/src/components/SetGuestUsername.vue
@@ -111,7 +111,7 @@ EventBus.once('joined-conversation', () => {
 	}
 })
 
-/** Update guest displayName from public event (e.g. @nextcloud/auth) */
+/** Update guest displayName from public event (e.g. `@nextcloud/auth`) */
 subscribe('user:info:changed', updateDisplayNameFromPublicEvent)
 onBeforeUnmount(() => {
 	unsubscribe('user:info:changed', updateDisplayNameFromPublicEvent)
diff --git a/src/services/conversationsService.ts b/src/services/conversationsService.ts
index 16762f0bd4..c6741ba1d9 100644
--- a/src/services/conversationsService.ts
+++ b/src/services/conversationsService.ts
@@ -375,7 +375,7 @@ async function changeListable(token: string, scope: setConversationListableParam
 }
 
 /**
- * Set mention permissions to allow or disallow mentioning @all for non-moderators
+ * Set mention permissions to allow or disallow mentioning `@all` for non-moderators
  *
  * @param token The token of the conversation to be modified
  * @param mentionPermissions The mention permissions to set
diff --git a/src/stores/actor.ts b/src/stores/actor.ts
index 7e28de2293..82f6e778ae 100644
--- a/src/stores/actor.ts
+++ b/src/stores/actor.ts
@@ -99,7 +99,7 @@ export const useActorStore = defineStore('actor', () => {
 	/**
 	 * Set the actor from the current user
 	 *
-	 * @param user A NextcloudUser object as returned by @nextcloud/auth
+	 * @param user A NextcloudUser object as returned by `@nextcloud/auth`
 	 * @param user.uid The user id of the user
 	 * @param user.displayName The display name of the user
 	 */
diff --git a/src/utils/e2ee/JitsiEncryptionWorkerContext.js b/src/utils/e2ee/JitsiEncryptionWorkerContext.js
index 10a4c66478..683b3d2c7b 100644
--- a/src/utils/e2ee/JitsiEncryptionWorkerContext.js
+++ b/src/utils/e2ee/JitsiEncryptionWorkerContext.js
@@ -217,8 +217,8 @@ export class Context {
 	async _decryptFrame(
 		encodedFrame,
 		keyIndex,
-			initialKey = undefined,
-			ratchetCount = 0,
+		initialKey = undefined,
+		ratchetCount = 0,
 	) {
 		const { encryptionKey } = this._cryptoKeyRing[keyIndex]
 		let { material } = this._cryptoKeyRing[keyIndex]
diff --git a/src/utils/handleUrl.ts b/src/utils/handleUrl.ts
index 5aebcec8fa..90224a1701 100644
--- a/src/utils/handleUrl.ts
+++ b/src/utils/handleUrl.ts
@@ -10,7 +10,7 @@ import { t } from '@nextcloud/l10n'
 import { generateUrl, getBaseUrl } from '@nextcloud/router'
 
 /**
- * Generate a full absolute link with @nextcloud/router.generateUrl
+ * Generate a full absolute link with `@nextcloud/router` generateUrl()
  *
  * @param url - path
  * @param params - parameters to be replaced into the address
diff --git a/src/utils/webrtc/simplewebrtc/simplewebrtc.js b/src/utils/webrtc/simplewebrtc/simplewebrtc.js
index 5a787e85ca..8bca3fdfa6 100644
--- a/src/utils/webrtc/simplewebrtc/simplewebrtc.js
+++ b/src/utils/webrtc/simplewebrtc/simplewebrtc.js
@@ -61,9 +61,9 @@ export default function SimpleWebRTC(opts) {
 	// Note that this is a coarse check; calling "getScreenMedia" may fail even
 	// if "supportScreenSharing" is true.
 	const screenSharingSupported
-			= (window.navigator.mediaDevices && window.navigator.mediaDevices.getDisplayMedia)
-				|| (window.navigator.webkitGetUserMedia)
-				|| (window.navigator.userAgent.match('Firefox'))
+		= (window.navigator.mediaDevices && window.navigator.mediaDevices.getDisplayMedia)
+			|| (window.navigator.webkitGetUserMedia)
+			|| (window.navigator.userAgent.match('Firefox'))
 	webrtcSupport.supportScreenSharing = window.location.protocol === 'https:' && screenSharingSupported
 
 	// attach detected support for convenience