plugins-nextcloud-mirror/spreed
1
0
Fork 0
mirror of https://github.com/nextcloud/spreed.git synced 2025-12-18 05:20:50 +01:00
Code Projects Releases Activity

fix(openapi): Fix user avatar API to not return empty arrays

Browse source 
Signed-off-by: Joas Schilling <coding@schilljs.com>
This commit is contained in:
Joas Schilling 2024-11-20 08:22:53 +01:00
parent 07a2623e6f
commit 6c2ad380ca
No known key found for this signature in database
GPG key ID: F72FA5B49FFA96B0
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
lib/Controller/TempAvatarController.php
View file

@ -36,7 +36,7 @@ class TempAvatarController extends OCSController {
/**
* Upload your avatar as a user
*
* @return DataResponse<Http::STATUS_OK, array<empty>, array{}>|DataResponse<Http::STATUS_BAD_REQUEST, array{message: string}, array{}>
* @return DataResponse<Http::STATUS_OK, null, array{}>|DataResponse<Http::STATUS_BAD_REQUEST, array{message: string}, array{}>
*
* 200: Avatar uploaded successfully
* 400: Uploading avatar is not possible
@ -96,7 +96,7 @@ class TempAvatarController extends OCSController {
$avatar = $this->avatarManager->getAvatar($this->userId);
$avatar->set($image);
return new DataResponse();
return new DataResponse(null);
} catch (NotSquareException $e) {
return new DataResponse(['message' => $e->getMessage()], Http::STATUS_BAD_REQUEST);
} catch (\Exception $e) {
@ -111,7 +111,7 @@ class TempAvatarController extends OCSController {
/**
* Delete your avatar as a user
*
* @return DataResponse<Http::STATUS_OK|Http::STATUS_BAD_REQUEST, array<empty>, array{}>
* @return DataResponse<Http::STATUS_OK, null, array{}>|DataResponse<Http::STATUS_BAD_REQUEST, array{error: 'avatar'}, array{}>
*
* 200: Avatar deleted successfully
* 400: Deleting avatar is not possible
@ -122,12 +122,12 @@ class TempAvatarController extends OCSController {
try {
$avatar = $this->avatarManager->getAvatar($this->userId);
$avatar->remove();
return new DataResponse();
return new DataResponse(null);
} catch (\Exception $e) {
$this->logger->error('Failed to delete avatar', [
'exception' => $e,
]);
return new DataResponse([], Http::STATUS_BAD_REQUEST);
return new DataResponse(['error' => 'avatar'], Http::STATUS_BAD_REQUEST);
}
}
}