plugins-nextcloud-mirror/spreed
1
0
Fork 0
mirror of https://github.com/nextcloud/spreed.git synced 2025-12-17 21:12:20 +01:00
Code Projects Releases Activity

fix(description): Increase description length to 2.000 characters

Browse source 
Signed-off-by: Joas Schilling <coding@schilljs.com>
This commit is contained in:
Joas Schilling 2025-01-14 15:14:52 +01:00
parent d1979824ec
commit 282540012a
No known key found for this signature in database
GPG key ID: F72FA5B49FFA96B0
26 changed files with 109 additions and 38 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
docs/capabilities.md
View file

@ -174,3 +174,4 @@
* `schedule-meeting` (local) - Whether logged-in participants can schedule meetings
* `config => chat => has-translation-task-providers` (local) - When true, translations can be done using the [OCS TaskProcessing API](https://docs.nextcloud.com/server/latest/developer_manual/client_apis/OCS/ocs-taskprocessing-api.html).
* `config => conversations => list-style` (local) - Whether conversation list should appear in certain way
* `config => conversations => description-length` (local) - The maximum length for conversation descriptions, currently 2000. Before this config was added the implicit limit was 500, since the existance of the feature capability `room-description`.

6
docs/conversation.md
View file

@ -269,9 +269,9 @@ Get all (for moderators and in case of "free selection") or the assigned breakou
* Endpoint: `/room/{token}/description`
* Data:
| field | type | Description |
|---------------|--------|--------------------------------------|
| `description` | string | New description for the conversation |
| field | type | Description |
|---------------|--------|--------------------------------------------------------------------------------------------|
| `description` | string | New description for the conversation (limited to 2.000 characters, was 500 before Talk 21) |
* Response:
- Status code:

2
lib/Capabilities.php
View file

@ -158,6 +158,7 @@ class Capabilities implements IPublicCapability {
'conversations' => [
'can-create',
'list-style',
'description-length',
],
'federation' => [
'enabled',
@ -236,6 +237,7 @@ class Capabilities implements IPublicCapability {
'can-create' => $user instanceof IUser && !$this->talkConfig->isNotAllowedToCreateConversations($user),
'force-passwords' => $this->talkConfig->isPasswordEnforced(),
'list-style' => $this->talkConfig->getConversationsListStyle($user?->getUID()),
'description-length' => Room::DESCRIPTION_MAXIMUM_LENGTH,
],
'federation' => [
'enabled' => false,

2
lib/Controller/RoomController.php
View file

@ -836,7 +836,7 @@ class RoomController extends AEnvironmentAwareOCSController {
/**
* Update the description of a room
*
* @param string $description New description
* @param string $description New description for the conversation (limited to 2.000 characters, was 500 before Talk 21)
* @return DataResponse<Http::STATUS_OK, TalkRoom, array{}>|DataResponse<Http::STATUS_BAD_REQUEST, array{error: 'type'|'value'}, array{}>
*
* 200: Description updated successfully

1
lib/ResponseDefinitions.php
View file

@ -360,6 +360,7 @@ namespace OCA\Talk;
* can-create: bool,
* force-passwords: bool,
* list-style: 'two-lines'|'compact',
* description-length: positive-int,
* },
* federation: array{
* enabled: bool,

2
lib/Room.php
View file

@ -76,7 +76,7 @@ class Room {
public const START_CALL_MODERATORS = 2;
public const START_CALL_NOONE = 3;
public const DESCRIPTION_MAXIMUM_LENGTH = 500;
public const DESCRIPTION_MAXIMUM_LENGTH = 2000;
public const HAS_FEDERATION_NONE = 0;
public const HAS_FEDERATION_TALKv1 = 1;

8
openapi-administration.json
View file

@ -243,7 +243,8 @@
"required": [
"can-create",
"force-passwords",
"list-style"
"list-style",
"description-length"
],
"properties": {
"can-create": {
@ -258,6 +259,11 @@
"two-lines",
"compact"
]
},
"description-length": {
"type": "integer",
"format": "int64",
"minimum": 1
}
}
},

8
openapi-backend-recording.json
View file

@ -176,7 +176,8 @@
"required": [
"can-create",
"force-passwords",
"list-style"
"list-style",
"description-length"
],
"properties": {
"can-create": {
@ -191,6 +192,11 @@
"two-lines",
"compact"
]
},
"description-length": {
"type": "integer",
"format": "int64",
"minimum": 1
}
}
},

8
openapi-backend-signaling.json
View file

@ -176,7 +176,8 @@
"required": [
"can-create",
"force-passwords",
"list-style"
"list-style",
"description-length"
],
"properties": {
"can-create": {
@ -191,6 +192,11 @@
"two-lines",
"compact"
]
},
"description-length": {
"type": "integer",
"format": "int64",
"minimum": 1
}
}
},

8
openapi-backend-sipbridge.json
View file

@ -219,7 +219,8 @@
"required": [
"can-create",
"force-passwords",
"list-style"
"list-style",
"description-length"
],
"properties": {
"can-create": {
@ -234,6 +235,11 @@
"two-lines",
"compact"
]
},
"description-length": {
"type": "integer",
"format": "int64",
"minimum": 1
}
}
},

8
openapi-bots.json
View file

@ -176,7 +176,8 @@
"required": [
"can-create",
"force-passwords",
"list-style"
"list-style",
"description-length"
],
"properties": {
"can-create": {
@ -191,6 +192,11 @@
"two-lines",
"compact"
]
},
"description-length": {
"type": "integer",
"format": "int64",
"minimum": 1
}
}
},

8
openapi-federation.json
View file

@ -219,7 +219,8 @@
"required": [
"can-create",
"force-passwords",
"list-style"
"list-style",
"description-length"
],
"properties": {
"can-create": {
@ -234,6 +235,11 @@
"two-lines",
"compact"
]
},
"description-length": {
"type": "integer",
"format": "int64",
"minimum": 1
}
}
},

10
openapi-full.json
View file

@ -377,7 +377,8 @@
"required": [
"can-create",
"force-passwords",
"list-style"
"list-style",
"description-length"
],
"properties": {
"can-create": {
@ -392,6 +393,11 @@
"two-lines",
"compact"
]
},
"description-length": {
"type": "integer",
"format": "int64",
"minimum": 1
}
}
},
@ -12590,7 +12596,7 @@
"properties": {
"description": {
"type": "string",
"description": "New description"
"description": "New description for the conversation (limited to 2.000 characters, was 500 before Talk 21)"
}
}
}

10
openapi.json
View file

@ -336,7 +336,8 @@
"required": [
"can-create",
"force-passwords",
"list-style"
"list-style",
"description-length"
],
"properties": {
"can-create": {
@ -351,6 +352,11 @@
"two-lines",
"compact"
]
},
"description-length": {
"type": "integer",
"format": "int64",
"minimum": 1
}
}
},
@ -12748,7 +12754,7 @@
"properties": {
"description": {
"type": "string",
"description": "New description"
"description": "New description for the conversation (limited to 2.000 characters, was 500 before Talk 21)"
}
}
}

1
src/__mocks__/capabilities.ts
View file

@ -139,6 +139,7 @@ export const mockedCapabilities: Capabilities = {
'can-create': true,
'force-passwords': false,
'list-style': 'two-lines',
'description-length': 2000,
},
federation: {
enabled: false,

2
src/types/openapi/openapi-administration.ts
View file

@ -250,6 +250,8 @@ export type components = {
"force-passwords": boolean;
/** @enum {string} */
"list-style": "two-lines" | "compact";
/** Format: int64 */
"description-length": number;
};
federation: {
enabled: boolean;

2
src/types/openapi/openapi-backend-recording.ts
View file

@ -84,6 +84,8 @@ export type components = {
"force-passwords": boolean;
/** @enum {string} */
"list-style": "two-lines" | "compact";
/** Format: int64 */
"description-length": number;
};
federation: {
enabled: boolean;

2
src/types/openapi/openapi-backend-signaling.ts
View file

@ -70,6 +70,8 @@ export type components = {
"force-passwords": boolean;
/** @enum {string} */
"list-style": "two-lines" | "compact";
/** Format: int64 */
"description-length": number;
};
federation: {
enabled: boolean;

2
src/types/openapi/openapi-backend-sipbridge.ts
View file

@ -165,6 +165,8 @@ export type components = {
"force-passwords": boolean;
/** @enum {string} */
"list-style": "two-lines" | "compact";
/** Format: int64 */
"description-length": number;
};
federation: {
enabled: boolean;

2
src/types/openapi/openapi-bots.ts
View file

@ -88,6 +88,8 @@ export type components = {
"force-passwords": boolean;
/** @enum {string} */
"list-style": "two-lines" | "compact";
/** Format: int64 */
"description-length": number;
};
federation: {
enabled: boolean;

2
src/types/openapi/openapi-federation.ts
View file

@ -196,6 +196,8 @@ export type components = {
"force-passwords": boolean;
/** @enum {string} */
"list-style": "two-lines" | "compact";
/** Format: int64 */
"description-length": number;
};
federation: {
enabled: boolean;

4
src/types/openapi/openapi-full.ts
View file

@ -2033,6 +2033,8 @@ export type components = {
"force-passwords": boolean;
/** @enum {string} */
"list-style": "two-lines" | "compact";
/** Format: int64 */
"description-length": number;
};
federation: {
enabled: boolean;
@ -6752,7 +6754,7 @@ export interface operations {
requestBody: {
content: {
"application/json": {
/** @description New description */
/** @description New description for the conversation (limited to 2.000 characters, was 500 before Talk 21) */
description: string;
};
};

4
src/types/openapi/openapi.ts
View file

@ -1533,6 +1533,8 @@ export type components = {
"force-passwords": boolean;
/** @enum {string} */
"list-style": "two-lines" | "compact";
/** Format: int64 */
"description-length": number;
};
federation: {
enabled: boolean;
@ -6336,7 +6338,7 @@ export interface operations {
requestBody: {
content: {
"application/json": {
/** @description New description */
/** @description New description for the conversation (limited to 2.000 characters, was 500 before Talk 21) */
description: string;
};
};

20
tests/integration/features/command/create.feature
View file

File diff suppressed because one or more lines are too long

22
tests/integration/features/conversation-5/set-description.feature
View file

File diff suppressed because one or more lines are too long

2
tests/php/CapabilitiesTest.php
View file

@ -159,6 +159,7 @@ class CapabilitiesTest extends TestCase {
'can-create' => false,
'force-passwords' => false,
'list-style' => 'two-lines',
'description-length' => 2000,
],
'federation' => [
'enabled' => false,
@ -297,6 +298,7 @@ class CapabilitiesTest extends TestCase {
'can-create' => $canCreate,
'force-passwords' => false,
'list-style' => 'two-lines',
'description-length' => 2000,
],
'federation' => [
'enabled' => false,