fix: adjust boolean logic

Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
This commit is contained in:
Elizabeth Danzberger 2025-11-19 17:17:43 -05:00
parent 2006bc3064
commit f568809649
No known key found for this signature in database
GPG key ID: 6B466A21DF5E753C
2 changed files with 2 additions and 1 deletions

View file

@ -39,7 +39,7 @@ class RegisterTemplateFileCreatorListener implements IEventListener {
} }
$user = $this->permissionManager->loggedInUser(); $user = $this->permissionManager->loggedInUser();
$userCanCreate = $this->permissionManager->isEnabledForUser($user) || $this->permissionManager->userCanEdit($user); $userCanCreate = $this->permissionManager->isEnabledForUser($user) && $this->permissionManager->userCanEdit($user);
if ($user && !$userCanCreate) { if ($user && !$userCanCreate) {
return; return;
} }

View file

@ -114,6 +114,7 @@ class RegisterTemplateFileCreatorListenerTest extends TestCase {
public function testHandleDoesNotRegisterIfUserCannotEdit() { public function testHandleDoesNotRegisterIfUserCannotEdit() {
$event = $this->createMock(RegisterTemplateCreatorEvent::class); $event = $this->createMock(RegisterTemplateCreatorEvent::class);
$event->method('getTemplateManager')->willReturn($this->templateManager); $event->method('getTemplateManager')->willReturn($this->templateManager);
$this->permissionManager->method('loggedInUser')->willReturn('user');
$this->permissionManager->method('isEnabledForUser')->willReturn(true); $this->permissionManager->method('isEnabledForUser')->willReturn(true);
$this->permissionManager->method('userCanEdit')->willReturn(false); $this->permissionManager->method('userCanEdit')->willReturn(false);
$this->capabilitiesService->method('getCapabilities')->willReturn(['something']); $this->capabilitiesService->method('getCapabilities')->willReturn(['something']);