From 894f9cffcfc75908478d5d7c1add54f41ba5a44a Mon Sep 17 00:00:00 2001
From: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Date: Sat, 6 Dec 2025 10:30:32 -0300
Subject: [PATCH] docs: add Git & Commit Practices section to copilot
 instructions

Added comprehensive section covering:
- Conventional Commits specification requirement
- DCO (Developer Certificate of Origin) signoff requirement
- Atomic commits best practices
- Examples of proper commit format
- Reference to official LibreSign commit guidelines

This ensures AI agents follow the project's commit conventions
documented at https://docs.libresign.coop/developer_manual/getting-started/commits.html

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
---
 .github/copilot-instructions.md | 66 +++++++++++++++++++++++++++++++++
 1 file changed, 66 insertions(+)

diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md
index 1cb07463c..22ee202b7 100644
--- a/.github/copilot-instructions.md
+++ b/.github/copilot-instructions.md
@@ -170,6 +170,72 @@ The second example is clear without comments because the method names describe e
 - Serial number validation is critical for CRL operations
 - Use `occ libresign:crl:*` commands for CRL operations
 
+## Git & Commit Practices
+
+LibreSign follows specific commit conventions. See the [official commit guidelines](https://docs.libresign.coop/developer_manual/getting-started/commits.html) for complete details.
+
+### Conventional Commits
+**All commits must follow [Conventional Commits](https://www.conventionalcommits.org/) specification.**
+
+**Commit format:**
+```
+<type>: <short description>
+
+[optional body]
+
+Signed-off-by: Your Name <your.email@example.com>
+```
+
+**Common types:**
+- `feat`: New feature
+- `fix`: Bug fix
+- `docs`: Documentation changes
+- `test`: Adding or updating tests
+- `refactor`: Code refactoring
+- `chore`: Maintenance tasks
+
+**Examples:**
+```bash
+# Feature
+git commit -s -m "feat: add CRL revocation endpoint"
+
+# Bug fix with description
+git commit -s -m "fix: validate certificate chain order
+
+Certificate chains with more than 3 certificates were failing
+validation due to incorrect ordering. The OrderCertificatesTrait
+now properly orders from end-entity to root.
+
+Fixes #1234"
+
+# Documentation
+git commit -s -m "docs: add donation links to GitHub Sponsors and Stripe"
+```
+
+### DCO (Developer Certificate of Origin)
+**Always sign off commits** using `git commit -s` or `git commit --signoff`.
+
+Every commit must include the `Signed-off-by` line to comply with the [DCO](https://developercertificate.org/).
+
+### Atomic Commits Best Practices
+- One logical change per commit
+- Commit should be self-contained and functional
+- Tests should pass after each commit
+- Makes git bisect and code review more effective
+
+**When to commit:**
+- After completing a logical unit of work
+- Before switching tasks or branches
+- After tests pass for the changes
+- At natural breakpoints in development
+
+**Bad practices to avoid:**
+- Committing unrelated changes together
+- Generic messages like "fixes", "wip", "misc changes"
+- Committing without signoff (`-s` flag)
+- Missing conventional commit type prefix
+- Large commits mixing multiple features/fixes
+
 ## Build & Release Process
 
 ### Development