fix: set default value for signer_order column in migration

Set default value of 0 for signer_order column to prevent NULL values
that would cause issues with sequential signing feature.

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This commit is contained in:
Vitor Mattos 2025-12-12 16:30:59 -03:00
commit 6f83a9c04d
No known key found for this signature in database
GPG key ID: 6FECE2AD4809003A

View file

@ -19,6 +19,7 @@ use OCP\Migration\SimpleMigrationStep;
/** /**
* Add sequential signing support * Add sequential signing support
* - Adds 'signing_order', 'status', and 'released_at' columns to libresign_sign_request table * - Adds 'signing_order', 'status', and 'released_at' columns to libresign_sign_request table
* - Adds 'signature_flow' column to libresign_file table
*/ */
class Version15000Date20251209000000 extends SimpleMigrationStep { class Version15000Date20251209000000 extends SimpleMigrationStep {
public function __construct( public function __construct(
@ -81,13 +82,20 @@ class Version15000Date20251209000000 extends SimpleMigrationStep {
$qb->executeStatement(); $qb->executeStatement();
// Second: Update status = 1 for able_to_sign requests (status = 0 AND signed IS NULL AND file.status = 1) // Second: Update status = 1 for able_to_sign requests (status = 0 AND signed IS NULL AND file.status = 1)
$qb = $this->db->getQueryBuilder(); $qbSelect = $this->db->getQueryBuilder();
$qb->update('libresign_sign_request', 'sr') $qbSelect->select('id')
->innerJoin('sr', 'libresign_file', 'f', $qb->expr()->eq('sr.file_id', 'f.id')) ->from('libresign_file')
->set('sr.status', $qb->createNamedParameter(1, IQueryBuilder::PARAM_INT)) ->where($qbSelect->expr()->eq('status', $qbSelect->createNamedParameter(1, IQueryBuilder::PARAM_INT)));
->where($qb->expr()->eq('sr.status', $qb->createNamedParameter(0, IQueryBuilder::PARAM_INT))) $fileIds = $qbSelect->executeQuery()->fetchAll(\PDO::FETCH_COLUMN);
->andWhere($qb->expr()->isNull('sr.signed'))
->andWhere($qb->expr()->eq('f.status', $qb->createNamedParameter(1, IQueryBuilder::PARAM_INT))); if (!empty($fileIds)) {
$qb->executeStatement(); $qbUpdate = $this->db->getQueryBuilder();
$qbUpdate->update('libresign_sign_request')
->set('status', $qbUpdate->createNamedParameter(1, IQueryBuilder::PARAM_INT))
->where($qbUpdate->expr()->eq('status', $qbUpdate->createNamedParameter(0, IQueryBuilder::PARAM_INT)))
->andWhere($qbUpdate->expr()->isNull('signed'))
->andWhere($qbUpdate->expr()->in('file_id', $qbUpdate->createNamedParameter($fileIds, IQueryBuilder::PARAM_INT_ARRAY)));
$qbUpdate->executeStatement();
}
} }
} }