plugins-nextcloud-mirror/libresign
1
0
Fork 0
mirror of https://github.com/LibreSign/libresign.git synced 2025-12-17 21:12:16 +01:00
Code Projects Releases Activity

refactor: move SignRequestStatus enum to dedicated Enum directory

Browse source 
Move SignRequestStatus from lib/Db/ to lib/Enum/ to follow project
convention of keeping all enums in a dedicated folder alongside
CRLStatus, CRLReason, CertificateType, and DocMdpLevel.

Updated namespace from OCA\Libresign\Db to OCA\Libresign\Enum and
adjusted all imports and references across:
- SignRequest entity (added import)
- ValidateHelper (updated FQN references)
- RequestSignatureService (updated FQN references)
- SequentialSigningService (updated import)
- SignFileService (updated FQN reference)

This improves code organization by consolidating all enum types in
one location.

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This commit is contained in:
Vitor Mattos 2025-12-11 11:42:11 -03:00
parent e5d703c51a
commit 552521e546
No known key found for this signature in database
GPG key ID: 6FECE2AD4809003A
6 changed files with 14 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
lib/Db/SignRequest.php
View file

@ -8,6 +8,7 @@ declare(strict_types=1);
namespace OCA\Libresign\Db;
use OCA\Libresign\Enum\SignRequestStatus;
use OCP\AppFramework\Db\Entity;
use OCP\DB\Types;

3
lib/Db/SignRequestStatus.php → lib/Enum/SignRequestStatus.php
View file

@ -1,12 +1,13 @@
<?php
declare(strict_types=1);
/**
* SPDX-FileCopyrightText: 2025 LibreCode coop and contributors
* SPDX-License-Identifier: AGPL-3.0-or-later
*/
namespace OCA\Libresign\Db;
namespace OCA\Libresign\Enum;
enum SignRequestStatus: int {
case DRAFT = 0;

4
lib/Helper/ValidateHelper.php
View file

@ -720,14 +720,14 @@ class ValidateHelper {
$signRequest = $this->signRequestMapper->getByUuid($uuid);
$status = $signRequest->getStatusEnum();
if ($status === \OCA\Libresign\Db\SignRequestStatus::DRAFT) {
if ($status === \OCA\Libresign\Enum\SignRequestStatus::DRAFT) {
throw new LibresignException(json_encode([
'action' => JSActions::ACTION_DO_NOTHING,
'errors' => [['message' => $this->l10n->t('You are not allowed to sign this document yet')]],
]));
}
if ($status === \OCA\Libresign\Db\SignRequestStatus::SIGNED) {
if ($status === \OCA\Libresign\Enum\SignRequestStatus::SIGNED) {
throw new LibresignException(json_encode([
'action' => JSActions::ACTION_DO_NOTHING,
'errors' => [['message' => $this->l10n->t('Document already signed')]],

12
lib/Service/RequestSignatureService.php
View file

@ -267,14 +267,14 @@ class RequestSignatureService {
$isNewSignRequest = !$signRequest->getId();
$currentStatus = $signRequest->getStatusEnum();
if ($isNewSignRequest || $currentStatus === \OCA\Libresign\Db\SignRequestStatus::DRAFT) {
if ($isNewSignRequest || $currentStatus === \OCA\Libresign\Enum\SignRequestStatus::DRAFT) {
$initialStatus = $this->determineInitialStatus($signingOrder);
$signRequest->setStatusEnum($initialStatus);
}
$this->saveSignRequest($signRequest);
$shouldNotify = $notify && $signRequest->getStatusEnum() === \OCA\Libresign\Db\SignRequestStatus::ABLE_TO_SIGN;
$shouldNotify = $notify && $signRequest->getStatusEnum() === \OCA\Libresign\Enum\SignRequestStatus::ABLE_TO_SIGN;
foreach ($identifyMethodsIncances as $identifyMethod) {
$identifyMethod->getEntity()->setSignRequestId($signRequest->getId());
@ -284,14 +284,14 @@ class RequestSignatureService {
return $signRequest;
}
private function determineInitialStatus(int $signingOrder): \OCA\Libresign\Db\SignRequestStatus {
private function determineInitialStatus(int $signingOrder): \OCA\Libresign\Enum\SignRequestStatus {
if (!$this->sequentialSigningService->isOrderedNumericFlow()) {
return \OCA\Libresign\Db\SignRequestStatus::ABLE_TO_SIGN;
return \OCA\Libresign\Enum\SignRequestStatus::ABLE_TO_SIGN;
}
return $signingOrder === 1
? \OCA\Libresign\Db\SignRequestStatus::ABLE_TO_SIGN
: \OCA\Libresign\Db\SignRequestStatus::DRAFT;
? \OCA\Libresign\Enum\SignRequestStatus::ABLE_TO_SIGN
: \OCA\Libresign\Enum\SignRequestStatus::DRAFT;
}
/**

3
lib/Service/SequentialSigningService.php
View file

@ -10,7 +10,8 @@ namespace OCA\Libresign\Service;
use OCA\Libresign\AppInfo\Application;
use OCA\Libresign\Db\SignRequestMapper;
use OCA\Libresign\Db\SignRequestStatus;
use OCA\Libresign\Enum\SignatureFlow;
use OCA\Libresign\Enum\SignRequestStatus;
use OCP\IAppConfig;
class SequentialSigningService {

2
lib/Service/SignFileService.php
View file

@ -376,7 +376,7 @@ class SignFileService {
$lastSignedDate = $this->getEngine()->getLastSignedDate();
$this->signRequest->setSigned($lastSignedDate);
$this->signRequest->setSignedHash($hash);
$this->signRequest->setStatusEnum(\OCA\Libresign\Db\SignRequestStatus::SIGNED);
$this->signRequest->setStatusEnum(\OCA\Libresign\Enum\SignRequestStatus::SIGNED);
$this->signRequestMapper->update($this->signRequest);