From 3f061158fc8fa044869218c4a119ba91ab2927b5 Mon Sep 17 00:00:00 2001
From: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Date: Thu, 11 Dec 2025 16:20:12 -0300
Subject: [PATCH] refactor: Replace Bullet component with NcChip and fix signer
 reactivity

- Replace custom Bullet component with NcChip from @nextcloud/vue
- Remove unused Bullet component
- Fix reactivity issue by passing signerIndex instead of currentSigner
- Signer component now fetches data from store reactively using computed property
- This ensures changes in store are properly reflected in the UI

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
---
 src/Components/Bullet/Bullet.vue   | 40 ------------------------------
 src/Components/Signers/Signer.vue  | 13 +++++-----
 src/Components/Signers/Signers.vue |  4 +--
 3 files changed, 9 insertions(+), 48 deletions(-)
 delete mode 100644 src/Components/Bullet/Bullet.vue

diff --git a/src/Components/Bullet/Bullet.vue b/src/Components/Bullet/Bullet.vue
deleted file mode 100644
index fc31a9c89..000000000
--- a/src/Components/Bullet/Bullet.vue
+++ /dev/null
@@ -1,40 +0,0 @@
-<!--
-  - SPDX-FileCopyrightText: 2024 LibreCode coop and LibreCode contributors
-  - SPDX-License-Identifier: AGPL-3.0-or-later
--->
-<template>
-	<div class="bullet__wrapper">
-		<span class="bullet__name">
-			{{ name }}
-		</span>
-	</div>
-</template>
-<script>
-export default {
-	name: 'Bullet',
-	props: {
-		name: {
-			type: String,
-			required: true,
-		},
-	},
-}
-</script>
-<style lang="scss" scoped>
-.bullet {
-	&__wrapper {
-		display: inline-block;
-		vertical-align: middle;
-		min-width: 0;
-		max-width: 100%;
-	}
-	&__name {
-		border-radius: 10px;
-		display: inline-flex;
-		max-width: 100%;
-		background-color: var(--color-background-dark);
-		padding-right: 8px;
-		padding-left: 8px;
-	}
-}
-</style>
diff --git a/src/Components/Signers/Signer.vue b/src/Components/Signers/Signer.vue
index 6f453e953..d2320041b 100644
--- a/src/Components/Signers/Signer.vue
+++ b/src/Components/Signers/Signer.vue
@@ -15,7 +15,10 @@
 		</template>
 		<template #subname>
 			<div class="signer-subname">
-				<Bullet v-for="method in identifyMethodsNames" :key="method" :name="method" />
+				<NcChip v-for="method in identifyMethodsNames"
+					:key="method"
+					:text="method"
+					:no-close="true" />
 				<NcChip :text="signer.statusText"
 					:type="chipType"
 					:icon-path="statusIconPath"
@@ -48,8 +51,6 @@ import NcAvatar from '@nextcloud/vue/components/NcAvatar'
 import NcChip from '@nextcloud/vue/components/NcChip'
 import NcListItem from '@nextcloud/vue/components/NcListItem'
 
-import Bullet from '../Bullet/Bullet.vue'
-
 import { useFilesStore } from '../../store/files.js'
 
 export default {
@@ -59,10 +60,9 @@ export default {
 		NcAvatar,
 		NcChip,
 		DragVertical,
-		Bullet,
 	},
 	props: {
-		currentSigner: {
+		signerIndex: {
 			type: Number,
 			required: true,
 		},
@@ -94,7 +94,8 @@ export default {
 	},
 	computed: {
 		signer() {
-			return this.filesStore.getFile().signers[this.currentSigner]
+			const file = this.filesStore.getFile()
+			return file?.signers?.[this.signerIndex]
 		},
 		signerName() {
 			return this.signer.displayName
diff --git a/src/Components/Signers/Signers.vue b/src/Components/Signers/Signers.vue
index 97b8709cb..746d18d92 100644
--- a/src/Components/Signers/Signers.vue
+++ b/src/Components/Signers/Signers.vue
@@ -15,7 +15,7 @@
 		<transition-group name="signer-list" tag="div">
 			<Signer v-for="(signer, index) in sortableSigners"
 				:key="signer.identify || index"
-				:current-signer="index"
+				:signer-index="index"
 				:event="event"
 				:draggable="!signer.signed">
 				<template #actions="{closeActions}">
@@ -27,7 +27,7 @@
 	<ul v-else>
 		<Signer v-for="(signer, index) in signers"
 			:key="signer.identify || index"
-			:current-signer="index"
+			:signer-index="index"
 			:event="event">
 			<template #actions="{closeActions}">
 				<slot name="actions" :signer="signer" :closeActions="closeActions" />