plugins-nextcloud-mirror/libresign
1
0
Fork 0
mirror of https://github.com/LibreSign/libresign.git synced 2025-12-18 05:20:45 +01:00
Code Projects Releases Activity

chore: convert string to constants

Browse source 
This will make more easy to add new activities.

Signed-off-by: Vitor Mattos <vitor@php.rio>
This commit is contained in:
Vitor Mattos 2025-05-16 13:17:57 -03:00
parent 0fa24fe615
commit 279e26ab95
No known key found for this signature in database
GPG key ID: B7AB4B76A7CA7318
8 changed files with 19 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
lib/Activity/Filter.php
View file

@ -9,11 +9,17 @@ declare(strict_types=1);
namespace OCA\Libresign\Activity;
use OCA\Libresign\AppInfo\Application;
use OCA\Libresign\Events\SendSignNotificationEvent;
use OCA\Libresign\Events\SignedEvent;
use OCP\Activity\IFilter;
use OCP\IL10N;
use OCP\IURLGenerator;
class Filter implements IFilter {
private const ALLOWED_TYPES = [
SendSignNotificationEvent::FILE_TO_SIGN,
SignedEvent::FILE_SIGNED,
];
public function __construct(
protected IL10N $l,
protected IURLGenerator $url,
@ -39,10 +45,7 @@ class Filter implements IFilter {
}
public function filterTypes(array $types) {
return array_intersect([
'file_to_sign',
'file_signed',
], $types);
return array_intersect(self::ALLOWED_TYPES, $types);
}
public function allowedApps() {

4
lib/Activity/Listener.php
View file

@ -78,7 +78,7 @@ class Listener implements IEventListener {
try {
$event
->setApp(Application::APP_ID)
->setType('file_to_sign')
->setType(SendSignNotificationEvent::FILE_TO_SIGN)
->setAuthor($actorId)
->setObject('signRequest', $signRequest->getId())
->setTimestamp($this->timeFactory->getTime())
@ -129,7 +129,7 @@ class Listener implements IEventListener {
try {
$activityEvent
->setApp(Application::APP_ID)
->setType('file_signed')
->setType(SignedEvent::FILE_SIGNED)
->setAuthor($actorId)
->setObject('signedFile', 10)
->setTimestamp($this->timeFactory->getTime())

3
lib/Activity/Settings/FileSigned.php
View file

@ -8,6 +8,7 @@ declare(strict_types=1);
namespace OCA\Libresign\Activity\Settings;
use OCA\Libresign\Events\SignedEvent;
use OCP\IL10N;
class FileSigned extends LibresignActivitySettings {
@ -20,7 +21,7 @@ class FileSigned extends LibresignActivitySettings {
* {@inheritdoc}
*/
public function getIdentifier(): string {
return 'file_signed';
return SignedEvent::FILE_SIGNED;
}
/**

3
lib/Activity/Settings/FileToSign.php
View file

@ -8,6 +8,7 @@ declare(strict_types=1);
namespace OCA\Libresign\Activity\Settings;
use OCA\Libresign\Events\SendSignNotificationEvent;
use OCP\IL10N;
class FileToSign extends LibresignActivitySettings {
@ -21,7 +22,7 @@ class FileToSign extends LibresignActivitySettings {
* @since 20.0.0
*/
public function getIdentifier(): string {
return 'file_to_sign';
return SendSignNotificationEvent::FILE_TO_SIGN;
}
/**

1
lib/Events/SendSignNotificationEvent.php
View file

@ -14,6 +14,7 @@ use OCA\Libresign\Service\IdentifyMethod\IIdentifyMethod;
use OCP\EventDispatcher\Event;
class SendSignNotificationEvent extends Event {
public const FILE_TO_SIGN = 'libresign_file_to_sign';
public function __construct(
private SignRequest $signRequest,
private FileEntity $libreSignFile,

1
lib/Events/SignedEvent.php
View file

@ -15,6 +15,7 @@ use OCP\EventDispatcher\Event;
use OCP\IUser;
class SignedEvent extends Event {
public const FILE_SIGNED = 'libresign_file_signed';
public function __construct(
private SignRequest $signRequest,
private FileEntity $libreSignFile,

4
lib/Listener/MailNotifyListener.php
View file

@ -56,7 +56,7 @@ class MailNotifyListener implements IEventListener {
IIdentifyMethod $identifyMethod,
): void {
try {
if ($this->isNotificationDisabledAtActivity($identifyMethod, 'file_to_sign')) {
if ($this->isNotificationDisabledAtActivity($identifyMethod, SendSignNotificationEvent::FILE_TO_SIGN)) {
return;
}
$email = '';
@ -89,7 +89,7 @@ class MailNotifyListener implements IEventListener {
IUser $user,
): void {
try {
if ($this->isNotificationDisabledAtActivity($identifyMethod, 'file_signed')) {
if ($this->isNotificationDisabledAtActivity($identifyMethod, SignedEvent::FILE_SIGNED)) {
return;
}

4
lib/Listener/NotificationListener.php
View file

@ -61,7 +61,7 @@ class NotificationListener implements IEventListener {
if (!$actor instanceof IUser) {
return;
}
if ($this->isNotificationDisabledAtActivity($identifyMethod, 'file_to_sign')) {
if ($this->isNotificationDisabledAtActivity($identifyMethod, SendSignNotificationEvent::FILE_TO_SIGN)) {
return;
}
$notification = $this->notificationManager->createNotification();
@ -99,7 +99,7 @@ class NotificationListener implements IEventListener {
$actorId = $libreSignFile->getUserId();
if ($this->isNotificationDisabledAtActivity($identifyMethod, 'file_signed')) {
if ($this->isNotificationDisabledAtActivity($identifyMethod, SignedEvent::FILE_SIGNED)) {
return;
}